Skip to content

Conversation

DominikB2014
Copy link
Contributor

Some initial work for drill down flows. This adds the create link button when editing a table and a corresponding modal. This stuff doesn't do anything yet as i'm working on some backend changes at the same time. And a lot will change between now and the final, putting this PR up to make it easier to review.

image image

@DominikB2014 DominikB2014 requested a review from a team as a code owner October 8, 2025 20:24
Copy link

linear bot commented Oct 8, 2025

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Oct 8, 2025
cursor[bot]

This comment was marked as outdated.

Copy link
Member

@narsaynorath narsaynorath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few things about extra navigation code, we don't need these here right?

Comment on lines +99 to +105
{
label: t('+ Create New Dashboard'),
value: 'new',
disabled: hasReachedDashboardLimit || isLoading,
tooltip: hasReachedDashboardLimit ? limitMessage : undefined,
tooltipOptions: {position: 'right', isHoverable: true},
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably don't want the user to be able to link to a creation flow, do we?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we might want to do that tbh, depends on what we decide UX wise, but I could definitely see a scenario where you create a summary dashboard off a widget.

@DominikB2014 DominikB2014 enabled auto-merge (squash) October 9, 2025 18:28
@DominikB2014 DominikB2014 merged commit 1b0021d into master Oct 9, 2025
45 checks passed
@DominikB2014 DominikB2014 deleted the dominikbuszowiecki/browse-68-add-ui-to-link-one-dashboard-to-another-in-the-frontend branch October 9, 2025 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants