-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
feat(dashboards): add create link button to table edit #101204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dashboards): add create link button to table edit #101204
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few things about extra navigation code, we don't need these here right?
{ | ||
label: t('+ Create New Dashboard'), | ||
value: 'new', | ||
disabled: hasReachedDashboardLimit || isLoading, | ||
tooltip: hasReachedDashboardLimit ? limitMessage : undefined, | ||
tooltipOptions: {position: 'right', isHoverable: true}, | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably don't want the user to be able to link to a creation flow, do we?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we might want to do that tbh, depends on what we decide UX wise, but I could definitely see a scenario where you create a summary dashboard off a widget.
Some initial work for drill down flows. This adds the create link button when editing a table and a corresponding modal. This stuff doesn't do anything yet as i'm working on some backend changes at the same time. And a lot will change between now and the final, putting this PR up to make it easier to review.